Create ledcWrite_RGB.ino #688
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adding the public domain example ledcWrite_demo_ESP32.ino to this repo. Added RGB to the name for people searching, added some comments, and renames things to make a bit more sense.
|
Ah I thought I commented on this... :D Please rename the demo to ledcWrite_RGB :) it's in examples of ESP32 so "demo" and "ESP32" are redundant here |
vseven
changed the title
renamed to ledcWrite_RGB.ino and added a couple more comments based on #689
|
Should be fixed. |
|
Oh I meant rename the folder/file as well :) else that long name will show in the menu |
…dcWrite_demo_ESP32_RGB.ino to libraries/ESP32/examples/AnalogOut/ledcWrite_RGB/ledcWrite_RGB.ino Renamed.
|
You make it seem like I know what I'm doing. Haha. I think I got it...had to google how to rename a commit, figured it out. Also unrelated but my ESP32 is still rebooting 5 - 10 times a day and I haven't heeard from the wifi guy. Want to use it for lights (RGB LEDs....go figure) and can't really ahve them turning off and on so if you have any other ideas on that (#653) let me know. |
|
I will poke again on the issue and see to get an answer :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adding the public domain example ledcWrite_demo_ESP32.ino to this repo. Added RGB to the name for people searching, added some comments, and renames things to make a bit more sense.